vndb/mithril-vndb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
978 commits 2 branches 0 tags 11 MiB
Commit graph

978 commits

This branch
This branch
All branches
Author SHA1 Message Date
pelonpelon
9d20a7cd8a Update mithril.component.md 2015-04-29 11:57:51 -05:00
pelonpelon
9c6cbab43e Update mithril.component.md 
- The term *rollback* should be explained or replaced
- caveat #3/#4: Should *root element* be changed to *top-most element* so as not to be confused with the element the component is mounted on ?
 2015-04-29 11:50:07 -05:00
pelonpelon
62e38287f7 Docs: mithril.component.m - Recommended changes 
These changes make the the text clearer to me. I did not want to change the voice of the text, but I tried to clear out some verbosity and improve consistency. I did my best not to interfere with the logic of the prose.

This document seems written to stand on its own, so I recommend the following additions:

- a general explanation of the args param as in `controller: function(args) {` and `view: function(ctrl, args) { ...`
- a specific explanation of how {data: args} in m.request() becomes url parameters (mithril.request.md could use the same treatment)
- an explanation of the extras param as in `controller: function(args, extras) {` and `view: function(ctrl, args, extras) { ...`
 2015-04-28 23:26:18 -05:00
Leo Horie
ea8853eec2 fix compile errors in ts file 2015-04-28 22:48:31 -04:00
Leo Horie
20179c17c7 Merge pull request #591 from blacha/next 
Fixing TS1016: A required parameter cannot follow an optional parameter
 2015-04-28 22:07:37 -04:00
Blayne Chard
23be76e03f Fixing TS1016: A required parameter cannot follow an optional parameter 2015-04-29 11:54:19 +12:00
Leo Horie
5ec440da21 add more caveats to docs 2015-04-28 16:23:38 -04:00
Leo Horie
47cc6a7b03 make it possible to return subtree directive as root 2015-04-28 15:56:43 -04:00
Leo Horie
9e26ef57f1 Merge remote-tracking branch 'origin/components' into components 2015-04-27 22:02:32 -04:00
Leo Horie
202f51c4ef remove outdated warning 2015-04-27 22:02:12 -04:00
Leo Horie
994056e683 Merge pull request #588 from barneycarroll/lineEndings 
Avoid EOL diff horror by enforcing CRLF on commit
 2015-04-27 08:19:36 -04:00
Barney
524a2c00e6 Avoid EOL diff horror by enforcing CRLF on commit 2015-04-26 12:53:35 +01:00
Leo Horie
0870839e90 don't allow extract option to break jsonp 2015-04-24 15:55:11 -04:00
Leo Horie
2177fbd446 improve docs 2015-04-24 08:22:42 -04:00
Leo Horie
82ceecd290 fix broken example in docs 2015-04-24 08:13:21 -04:00
Leo Horie
86deb2fcb6 oops. fix brokenness 2015-04-22 23:00:34 -04:00
Leo Horie
24a8b0b31c add some points to address common criticism 2015-04-22 22:46:01 -04:00
Leo Horie
fceb02e887 add note about MSX in guide 2015-04-22 22:34:31 -04:00
Leo Horie
585f1fe925 clean up markup for tweets 2015-04-22 22:03:12 -04:00
Leo Horie
7127df6e0e show some newer tweets 2015-04-22 21:49:54 -04:00
Leo Horie
f70b4cc01b update size 2015-04-22 21:18:55 -04:00
Leo Horie
5a786009c5 remove references to m.module 2015-04-22 21:18:41 -04:00
Leo Horie
ab1e91a221 tweak editorconfig preferences 2015-04-22 21:00:11 -04:00
Leo Horie
2de9985a34 throw error if entering infinite redirect loop 2015-04-22 20:45:37 -04:00
Leo Horie
f0b20da30a update docs about config: m.route 2015-04-22 20:32:39 -04:00
Leo Horie
51d073e414 Merge remote-tracking branch 'origin/next' into components 2015-04-22 20:22:12 -04:00
Leo Horie
b0c4482ecc Merge pull request #578 from therebelrobot/bugfix/m.route-redirect-url-update 
Added check for this.attrs into m.route
 2015-04-22 20:21:43 -04:00
Leo Horie
f557b3cd5c Merge remote-tracking branch 'origin/next' into components 2015-04-22 20:21:21 -04:00
Leo Horie
675f66a44b improve error message 2015-04-22 20:20:43 -04:00
Leo Horie
aebf16b618 Merge pull request #579 from alexander-travov/next 
Fix URI.js url
 2015-04-22 15:09:30 -04:00
Alexander Travov
99b78b0e7c Fix URI.js url 2015-04-22 21:24:03 +03:00
Trent Oswald
1d6405e547 Added check for this.attrs into m.route 
m.route('path'), when called programmatically (not attached to an anchor
tag), did not update the url in the navigation bar. I tracked it to this
error, where it is searching for an elements attributes, sepecifically
the this.attrs.href, which did not exist when called programatically.
The error returning was "Cannot read property 'href' of undefined",
which linked back to line 618 in the mithril core file.

I added a simple check to see if this.attrs exists before calling in
.href. Fixed it like a charm. I tried to follow the current coding
style, but let me know if there is something amiss in my change.

I ran both grunt test and grunt testall and everything seemed to run
perfect.
 2015-04-22 10:31:33 -06:00
Leo Horie
8214d56411 clean up 2015-04-21 21:45:33 -04:00
Leo Horie
3137b63b12 add docs about infinite loop pitfall 2015-04-21 21:45:21 -04:00
Leo Horie
926ed2d692 teardown #571 test properly 2015-04-21 20:55:23 -04:00
Leo Horie
16bad63113 Merge pull request #575 from tobscure/redraw-all-fix 
Add test case for #571
 2015-04-21 20:54:23 -04:00
Leo Horie
8f9cbb751f teardown route tests properly 2015-04-21 20:53:54 -04:00
Leo Horie
2454e31f64 Merge remote-tracking branch 'origin/next' into components 2015-04-21 20:22:47 -04:00
Leo Horie
d09ec5bf8e Merge pull request #577 from tobscure/add-editor-config 
Add EditorConfig
 2015-04-21 20:16:59 -04:00
Leo Horie
f4dd244f0e Merge pull request #576 from tobscure/prevent-redraw-hooks 
Prevent scroll on redraw called inside onunload if previous onunload calls preventDefault
 2015-04-21 18:49:05 -04:00
Toby Zerner
38b8b1b654 Add EditorConfig 2015-04-22 07:51:31 +09:30
Toby Zerner
23766a5cbe Prevent scroll on redraw inside onunload if previous onunload calls preventDefault 
https://github.com/lhorie/mithril.js/issues/560#issuecomment-93876904
 2015-04-22 07:48:43 +09:30
Toby Zerner
337ec325b3 Add test case 2015-04-22 07:31:59 +09:30
Leo Horie
c5b0f068f1 Merge pull request #568 from johnmarkos/git-notrack-archive 
Removed archive/v0.1.34/mithril-tests.js from git.
 2015-04-21 10:54:31 -04:00
Leo Horie
3fd7013d90 Merge pull request #571 from tobscure/redraw-all-fix 
Fix nodes without config not being cleared when redraw strategy is all
 2015-04-21 10:53:20 -04:00
Leo Horie
d6911d105b clean up unused test code 2015-04-21 09:24:13 -04:00
Leo Horie
dbee97bf04 ensure component lifecycle works for components with implicit controllers 2015-04-21 09:23:55 -04:00
Leo Horie
7b96a583b3 improve docs 2015-04-21 08:20:00 -04:00
Leo Horie
c0865c6b85 update change log 2015-04-20 22:19:58 -04:00
Toby Zerner
46406095f2 Fix nodes without config not being cleared when redraw strategy is all 
Nodes without a config function never get a configContext, and thus the
logic to ensure they are cleared on a full redraw was broken.
 2015-04-21 11:47:53 +09:30