Leo Horie
ab1e91a221
tweak editorconfig preferences
2015-04-22 21:00:11 -04:00
Leo Horie
2de9985a34
throw error if entering infinite redirect loop
2015-04-22 20:45:37 -04:00
Leo Horie
f0b20da30a
update docs about config: m.route
2015-04-22 20:32:39 -04:00
Leo Horie
51d073e414
Merge remote-tracking branch 'origin/next' into components
2015-04-22 20:22:12 -04:00
Leo Horie
b0c4482ecc
Merge pull request #578 from therebelrobot/bugfix/m.route-redirect-url-update
...
Added check for this.attrs into m.route
2015-04-22 20:21:43 -04:00
Leo Horie
f557b3cd5c
Merge remote-tracking branch 'origin/next' into components
2015-04-22 20:21:21 -04:00
Leo Horie
675f66a44b
improve error message
2015-04-22 20:20:43 -04:00
Leo Horie
aebf16b618
Merge pull request #579 from alexander-travov/next
...
Fix URI.js url
2015-04-22 15:09:30 -04:00
Alexander Travov
99b78b0e7c
Fix URI.js url
2015-04-22 21:24:03 +03:00
Trent Oswald
1d6405e547
Added check for this.attrs into m.route
...
m.route('path'), when called programmatically (not attached to an anchor
tag), did not update the url in the navigation bar. I tracked it to this
error, where it is searching for an elements attributes, sepecifically
the this.attrs.href, which did not exist when called programatically.
The error returning was "Cannot read property 'href' of undefined",
which linked back to line 618 in the mithril core file.
I added a simple check to see if this.attrs exists before calling in
.href. Fixed it like a charm. I tried to follow the current coding
style, but let me know if there is something amiss in my change.
I ran both grunt test and grunt testall and everything seemed to run
perfect.
2015-04-22 10:31:33 -06:00
Leo Horie
8214d56411
clean up
2015-04-21 21:45:33 -04:00
Leo Horie
3137b63b12
add docs about infinite loop pitfall
2015-04-21 21:45:21 -04:00
Leo Horie
926ed2d692
teardown #571 test properly
2015-04-21 20:55:23 -04:00
Leo Horie
16bad63113
Merge pull request #575 from tobscure/redraw-all-fix
...
Add test case for #571
2015-04-21 20:54:23 -04:00
Leo Horie
8f9cbb751f
teardown route tests properly
2015-04-21 20:53:54 -04:00
Leo Horie
2454e31f64
Merge remote-tracking branch 'origin/next' into components
2015-04-21 20:22:47 -04:00
Leo Horie
d09ec5bf8e
Merge pull request #577 from tobscure/add-editor-config
...
Add EditorConfig
2015-04-21 20:16:59 -04:00
Leo Horie
f4dd244f0e
Merge pull request #576 from tobscure/prevent-redraw-hooks
...
Prevent scroll on redraw called inside onunload if previous onunload calls preventDefault
2015-04-21 18:49:05 -04:00
Toby Zerner
38b8b1b654
Add EditorConfig
2015-04-22 07:51:31 +09:30
Toby Zerner
23766a5cbe
Prevent scroll on redraw inside onunload if previous onunload calls preventDefault
...
https://github.com/lhorie/mithril.js/issues/560#issuecomment-93876904
2015-04-22 07:48:43 +09:30
Toby Zerner
337ec325b3
Add test case
2015-04-22 07:31:59 +09:30
Leo Horie
c5b0f068f1
Merge pull request #568 from johnmarkos/git-notrack-archive
...
Removed archive/v0.1.34/mithril-tests.js from git.
2015-04-21 10:54:31 -04:00
Leo Horie
3fd7013d90
Merge pull request #571 from tobscure/redraw-all-fix
...
Fix nodes without config not being cleared when redraw strategy is all
2015-04-21 10:53:20 -04:00
Leo Horie
d6911d105b
clean up unused test code
2015-04-21 09:24:13 -04:00
Leo Horie
dbee97bf04
ensure component lifecycle works for components with implicit controllers
2015-04-21 09:23:55 -04:00
Leo Horie
7b96a583b3
improve docs
2015-04-21 08:20:00 -04:00
Leo Horie
c0865c6b85
update change log
2015-04-20 22:19:58 -04:00
Toby Zerner
46406095f2
Fix nodes without config not being cleared when redraw strategy is all
...
Nodes without a config function never get a configContext, and thus the
logic to ensure they are cleared on a full redraw was broken.
2015-04-21 11:47:53 +09:30
Leo Horie
c9be4b30ce
improve docs about redrawing
2015-04-20 22:16:27 -04:00
Leo Horie
15c0686b27
prevent early redraw of component w/ routed async components
2015-04-20 12:41:51 -04:00
Leo Horie
cf1f316bee
don't redraw component before async service finishes
2015-04-20 11:20:04 -04:00
Leo Horie
cc8cac358a
#567 reset scroll before config runs
2015-04-18 22:39:59 -04:00
Leo Horie
b847ca1067
add regression test
2015-04-18 09:17:48 -04:00
Leo Horie
ec8e42a923
clean up dead variable
2015-04-18 09:17:37 -04:00
Leo Horie
6c32afea43
#569 fix diff edge case w/ select input
2015-04-17 22:21:03 -04:00
Leo Horie
006445960b
clean up
2015-04-17 22:13:15 -04:00
Leo Horie
e4906706b1
fix template compiler edge cases
2015-04-17 22:09:14 -04:00
Leo Horie
981fae0a20
Merge branch 'next' into components
2015-04-17 08:14:37 -04:00
Leo Horie
fdeb6f9512
Merge remote-tracking branch 'origin/next' into next
2015-04-17 08:14:24 -04:00
Leo Horie
06721ceb76
js.org badge
2015-04-17 08:14:07 -04:00
John Markos O'Neill
0dbd022c62
Removed archive/v0.1.34/mithril-tests.js from git.
...
archive/ is already in .gitignore. This change removes the file
from tracking as well. It gets re-generated by `npm test`.
2015-04-16 23:35:41 -07:00
Leo Horie
1a97d3db95
Merge pull request #563 from johnmarkos/install-grunt
...
Install grunt explicitly to stop warnings.
2015-04-16 08:01:23 -04:00
Leo Horie
bca33a0b78
fix docs about using bleeding edge from npm
2015-04-15 22:41:15 -04:00
Leo Horie
fce5f4b86f
prevent dom recreation if only class value changed
2015-04-15 22:40:50 -04:00
John Markos O'Neill
d4b5ebd90e
Install grunt explicitly to stop warnings.
2015-04-15 16:53:58 -07:00
Leo Horie
81e9d64912
Merge pull request #561 from shibukawa/patch-2
...
Duplicated senteces
2015-04-15 13:31:56 -04:00
Leo Horie
94d804d850
#554 don't initialize ctx.retain
2015-04-14 22:47:56 -04:00
Yoshiki Shibukawa
3eac4a2596
Duplicated senteces
...
Signature document for "background" option contains almost same meaning sentences. First one has more information, and I think separated warning message is easy to read (difficult to pass through), I changed like this:
* Remove a simpler sentence.
* Move a detailed sentence to the bottom where simpler sentence was originally.
2015-04-15 11:10:27 +09:00
Leo Horie
e7992553d9
#560 prevent scroll on next redraw if onunload calls preventDefault
2015-04-14 21:51:56 -04:00
Leo Horie
ce883b4089
#555 don't cache controller if redraw strategy is all
2015-04-14 21:38:21 -04:00
